Skip to content

Commit

Permalink
fix(eslint-config): bump eslint-plugin-prettier, add more common magi…
Browse files Browse the repository at this point in the history
…c numbers
  • Loading branch information
JounQin committed Sep 18, 2019
1 parent 1371749 commit 01d94a3
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 7 deletions.
19 changes: 18 additions & 1 deletion packages/eslint-config/_util.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,21 @@ exports.webpackSpecVars = [
'DEBUG',
]

exports.magicNumbers = [-1, 0, 1, 2, 7, 12, 24, 60, 500, 1000]
exports.magicNumbers = [
-1,
0,
1,
2,
7,
12,
15,
24,
30,
50,
60,
100,
365,
500,
1000,
3600,
]
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"eslint-plugin-jest": "^22.17.0",
"eslint-plugin-mdx": "^1.5.0",
"eslint-plugin-node": "^10.0.0",
"eslint-plugin-prettier": "^3.1.0",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-react": "^7.14.3",
"eslint-plugin-react-hooks": "^2.0.1",
Expand Down
1 change: 0 additions & 1 deletion tests/test.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default Vue.extend({
},
async reverse() {
await new Promise(resolve => {
// eslint-disable-next-line no-magic-numbers
setTimeout(resolve, 500)
})
this.msg = this.msg
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5176,10 +5176,10 @@ eslint-plugin-prettier@^2.2.0:
fast-diff "^1.1.1"
jest-docblock "^21.0.0"

eslint-plugin-prettier@^3.1.0:
version "3.1.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.0.tgz#8695188f95daa93b0dc54b249347ca3b79c4686d"
integrity sha512-XWX2yVuwVNLOUhQijAkXz+rMPPoCr7WFiAl8ig6I7Xn+pPVhDhzg4DxHpmbeb0iqjO9UronEA3Tb09ChnFVHHA==
eslint-plugin-prettier@^3.1.1:
version "3.1.1"
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.1.tgz#507b8562410d02a03f0ddc949c616f877852f2ba"
integrity sha512-A+TZuHZ0KU0cnn56/9mfR7/KjUJ9QNVXUhwvRFSR7PGPe0zQR6PTkmyqg1AtUUEOzTqeRsUwyKFh0oVZKVCrtA==
dependencies:
prettier-linter-helpers "^1.0.0"

Expand Down

0 comments on commit 01d94a3

Please sign in to comment.