Websocket protocol upgrade failed in firefox

[fengyc]

Firefox sends header Connection: keep-alive, Upgrade, that the check_header function could not handle.

rust-websocket-lite/websocket-codec/src/upgrade.rs

Lines 73 to 88 in de4b4a6

	let mut check_header = |name, expected| {
	let actual = header(name)?;
	if actual.eq_ignore_ascii_case(expected) {
	Ok(())
	} else {
	Err(format!(
	"client provided incorrect {name} header: expected {expected}, got {actual}",
	name = name,
	expected = expected,
	actual = actual
	))
	}
	};
	check_header("Upgrade", "websocket")?;
	check_header("Connection", "Upgrade")?;

actual.eq_ignore_ascii_case(expected) should be replaced with containsXXX.

[1tgr]

Thanks! This is the standard Firefox websocket client talking to the Rust server?

[fengyc]

Yes, the latest firefox 77.0.1.

[1tgr]

I pushed a change to the firefox branch that fixes it for me. Are you able to test it on the branch before I make a release to crates.io?

[fengyc]

Tested. Works for me.

[1tgr]

Pushed: https://crates.io/crates/websocket-lite/0.3.5