Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package-lock.json should be committed #16

Closed
Jameskmonger opened this issue Jul 9, 2023 · 0 comments · Fixed by #18
Closed

package-lock.json should be committed #16

Jameskmonger opened this issue Jul 9, 2023 · 0 comments · Fixed by #18

Comments

@Jameskmonger
Copy link
Contributor

We should commit package-lock.json and update the README to use npm ci.

https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json
@Jameskmonger Jameskmonger mentioned this issue Jul 9, 2023
Merged
Jameskmonger added a commit to Jameskmonger/2004scape-server that referenced this issue Jul 9, 2023
@Jameskmonger
build: 🔧 add package-lock.json to source control
ff70a83 
closes 2004Scape#16
@Pazaz Pazaz closed this as completed in #18 Jul 9, 2023
Pazaz pushed a commit that referenced this issue Jul 9, 2023
@Jameskmonger
build: 🔧 add package-lock.json to source control (#18)
a6c9929 
* build: 🔧 add package-lock.json to source control

closes #16

* docs: 📝 recommend `npm ci` in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: 🔧 add package-lock.json to source control Jameskmonger/2004scape-server
1 participant
@Jameskmonger