Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider containerisation through Docker #17

Closed
Jameskmonger opened this issue Jul 9, 2023 · 1 comment
Closed

Consider containerisation through Docker #17

Jameskmonger opened this issue Jul 9, 2023 · 1 comment

Comments

@Jameskmonger
Copy link
Contributor

The setup steps will be more simple and more easily guaranteed to work, plus it means that whatever version of Node/Java etc the user has installed locally (if at all) is irrelevant, and will be controlled through the image.

Considerations:

  • Multi-step Docker image can be used to have effectively a "runtime" build (slimmer) with a "dev" step attached to the end in order to handle hot reloading etc.
@Jameskmonger
Copy link
Contributor Author

We have had more new-joiners to the team struggle with incorrect Node versions, I am going to bump this up my personal priority list and take a look soon

Jameskmonger added a commit to Jameskmonger/2004scape-server that referenced this issue Jul 31, 2023
This makes it easier to run as dev but also will make Dockerisation (see 2004Scape#17)
Pazaz pushed a commit that referenced this issue Jul 31, 2023
This makes it easier to run as dev but also will make Dockerisation (see #17)
@Pazaz Pazaz closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants