Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HRtoVRChat] Improve isHRBeat #5

Open
200Tigersbloxed opened this issue Oct 12, 2021 · 0 comments
Open

[HRtoVRChat] Improve isHRBeat #5

200Tigersbloxed opened this issue Oct 12, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@200Tigersbloxed
Copy link
Owner

Currently, isHRBeat is very inaccurate and doesn't update through the network properly as the wait interval time given for the parameter to update (0.1 seconds) is not enough time.

The equation used needs to be improved to accurately guess how often the heart beats from the BPM.

MainMod.cs Line 261, the calculation that's made to guess when the heart is beating.

try { waitTime = 1 / (HR / 60); } catch (Exception) { /*Just a Divide by Zero Exception*/ }

(https://github.com/200Tigersbloxed/UnityMods/blob/main/HRtoVRChat/HRtoVRChat/MainMod.cs#L261)

This number that's guessed also needs to be buffed to give the network enough time to sync the parameter globally, which is the big problem.

@200Tigersbloxed 200Tigersbloxed added enhancement New feature or request help wanted Extra attention is needed labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant