Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides Embers RSVP onerror default #8

Closed
jrhe opened this issue Apr 14, 2015 · 2 comments
Closed

Overrides Embers RSVP onerror default #8

jrhe opened this issue Apr 14, 2015 · 2 comments

Comments

@jrhe
Copy link
Contributor

jrhe commented Apr 14, 2015

Ember provides a customised default for RSVP.onerror. We override this and so it removes a lot of the behaviour they have added. No idea if we need all of this but one problem which manifested itself is the catching of TransitionAborted errors which the ember version filters out.

https://github.com/emberjs/ember.js/blob/85550ca7f91883838953e736caa6ef51daabf255/packages/ember-runtime/lib/ext/rsvp.js#L53

Theoretically we don't actually need to override this as it defaults to Ember.onerror if defined and we define it.

@jrhe
Copy link
Contributor Author

jrhe commented Jun 9, 2015

Any comments about this? Why do we set both RSVPs error handler and Ember.onerror when RSVP delegates the the latter anyway automatically?

@bantic
Copy link
Member

bantic commented Jan 6, 2016

@jrhe Sorry, this issue got lost in the shuffle before. The latest version of this addon, 0.1.0, is a little more conservative about only registering error handlers for window.onerror and Ember.onerror. It also provides an airbrake service so that you can explicitly handle/notify errors however you would like. This may help address your issue. To use it, you'll want to remove ember-cli-airbrake from your package.json (and potentially also from your node_modules/) and ember install ember-cli-airbrake@0.1.0.
I'm closing this issue for now, please reopen if the updated package doesn't improve your situation. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants