-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 - Rework/separe elements components #220
V1 - Rework/separe elements components #220
Conversation
6f17b7e
to
1146ecf
Compare
1146ecf
to
952bc29
Compare
94f51ab
to
505d24f
Compare
assets/styl/_base/_svg.styl
Outdated
@@ -1,2 +1,9 @@ | |||
// Symbols |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still Symbols
?
assets/styl/_components/_form.styl
Outdated
// | ||
// Special form components. | ||
// A colette form should have `form` class to benefit exevy features provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every
{% block block_body_content %} | ||
{% for item in list %} | ||
<li class="block-list-item" {{ loop.index > itemPerPage ? ' aria-hidden="true"' }}> | ||
{% include 'card.twig' with { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be {{ include('card.twig', {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twig js don't work support named arguments :sad:
twigjs/twig.js#410
assets/styl/_base/_form.styl
Outdated
// Form elements | ||
// | ||
// Colette comes with basic CSS to style forms' elements. | ||
// Colette comes with basic CSS to style form’s elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
assets/styl/_components/card.twig
Outdated
@@ -0,0 +1,49 @@ | |||
{# Card | |||
# | |||
# @param uri isDated (optional) (default true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not an uri
it's a bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha pasted from vega
assets/styl/_components/card.twig
Outdated
# @param str theme (optional) override theme | ||
# @param bool lazyloadImg (optional) image lazyload (default false) | ||
# @param array classes (optional) classes array added to each cards (defaut []) | ||
# @param str attributes (optional) (default '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be consistent in your twig files, use either string
or str
, but not both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha pasted from vega
505d24f
to
ee3d9b0
Compare
2e96e80
to
e8199f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
v1 beta
.btnSkin-…
btnIcon
box
styl (remove border and add rounded corners and shadow).linkwithsvg
to.linkIcon
_settings.styl
in multiple files in_settings/
$svgLogo
to$mediaPlaceholder
$svgLogoStyle
to$mediaPlaceholder-style
$gutter
and$columns
to$grid-gutter
and$grid-columns
$font-base
,$font-headings
and$font-secondary
and$fontstack-base
,$fontstack-headings
and$fontstack-secondary
.form-single-row
to.formSingleInput
.formSingleInput-input
and.formSingleInput-btn
to make css selector lighter.form-single-row
in benefit to.btnSkin-…