V1 - Rework/separe elements components #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuran
force-pushed
the
rework/separe-elements-components
branch
from
6f17b7e
to
1146ecf
Compare
ryuran
force-pushed
the
rework/separe-elements-components
branch
from
1146ecf
to
952bc29
Compare
ryuran
force-pushed
the
rework/separe-elements-components
branch
2 times, most recently
from
94f51ab
to
505d24f
Compare
mallier
reviewed
Mar 20, 2018
assets/styl/_base/_svg.styl
Outdated
| @@ -1,2 +1,9 @@ | |||
| // Symbols | |||
assets/styl/_components/_form.styl
Outdated
| // | ||
| // Special form components. | ||
| // A colette form should have `form` class to benefit exevy features provided |
| {% block block_body_content %} | ||
| {% for item in list %} | ||
| <li class="block-list-item" {{ loop.index > itemPerPage ? ' aria-hidden="true"' }}> | ||
| {% include 'card.twig' with { |
There was a problem hiding this comment.
Twig js don't work support named arguments :sad:
twigjs/twig.js#410
j0k3r
reviewed
Mar 21, 2018
assets/styl/_base/_form.styl
Outdated
| // Form elements | ||
| // | ||
| // Colette comes with basic CSS to style forms' elements. | ||
| // Colette comes with basic CSS to style form’s elements. |
assets/styl/_components/card.twig
Outdated
| @@ -0,0 +1,49 @@ | |||
| {# Card | |||
| # | |||
| # @param uri isDated (optional) (default true) | |||
There was a problem hiding this comment.
haha pasted from vega
assets/styl/_components/card.twig
Outdated
| # @param str theme (optional) override theme | ||
| # @param bool lazyloadImg (optional) image lazyload (default false) | ||
| # @param array classes (optional) classes array added to each cards (defaut []) | ||
| # @param str attributes (optional) (default '') |
There was a problem hiding this comment.
You should be consistent in your twig files, use either string or str, but not both
There was a problem hiding this comment.
haha pasted from vega
ryuran
force-pushed
the
rework/separe-elements-components
branch
from
505d24f
to
ee3d9b0
Compare
ryuran
force-pushed
the
rework/separe-elements-components
branch
from
2e96e80
to
e8199f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 beta
.btnSkin-…btnIconboxstyl (remove border and add rounded corners and shadow).linkwithsvgto.linkIcon_settings.stylin multiple files in_settings/$svgLogoto$mediaPlaceholder$svgLogoStyleto$mediaPlaceholder-style$gutterand$columnsto$grid-gutterand$grid-columns$font-base,$font-headingsand$font-secondaryand$fontstack-base,$fontstack-headingsand$fontstack-secondary.form-single-rowto.formSingleInput.formSingleInput-inputand.formSingleInput-btnto make css selector lighter.form-single-rowin benefit to.btnSkin-…