Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List jQuery as dependency #344

Closed
sjelfull opened this issue Nov 4, 2016 · 9 comments
Closed

List jQuery as dependency #344

sjelfull opened this issue Nov 4, 2016 · 9 comments

Comments

@sjelfull
Copy link

sjelfull commented Nov 4, 2016

I think a note should be added that list jQuery as a dependency.

@znap026
Copy link
Contributor

znap026 commented Nov 21, 2016

Why has it become a dependency? it wasn't needed before. I'm trying to work out what requires it?

@sjelfull
Copy link
Author

sjelfull commented Nov 22, 2016

I don't know anything about the history of the project, but it's obviously required?

https://github.com/23/resumable.js/blob/master/resumable.js#L12

@steffentchr
Copy link
Member

This is on me for missing this in the original PR that introduced this.

@thewilli you introduced this check, but no other references to jQuery apart from this?

@Arood
Copy link

Arood commented Dec 1, 2016

This is hilarious. Not only does it not use jQuery, but Resumable seems to use $ for it's own thing https://github.com/23/resumable.js/blob/master/resumable.js#L39

@znap026
Copy link
Contributor

znap026 commented Dec 1, 2016

Exactly why was this added?

@steffentchr
Copy link
Member

Pinging @thewilli again -- otherwise planning to remove it over the weekend.

@boris-glumpler
Copy link

Any news on this?

@boris-glumpler
Copy link

Cheers!

@thewilli
Copy link

thewilli commented Dec 8, 2016

sorry, I had some private, project-related content included when creating the MR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants