-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List jQuery as dependency #344
Comments
Why has it become a dependency? it wasn't needed before. I'm trying to work out what requires it? |
I don't know anything about the history of the project, but it's obviously required? https://github.com/23/resumable.js/blob/master/resumable.js#L12 |
This is on me for missing this in the original PR that introduced this. @thewilli you introduced this check, but no other references to jQuery apart from this? |
This is hilarious. Not only does it not use jQuery, but Resumable seems to use $ for it's own thing https://github.com/23/resumable.js/blob/master/resumable.js#L39 |
Exactly why was this added? |
Pinging @thewilli again -- otherwise planning to remove it over the weekend. |
Any news on this? |
Cheers! |
sorry, I had some private, project-related content included when creating the MR |
I think a note should be added that list jQuery as a dependency.
The text was updated successfully, but these errors were encountered: