Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required minimum Android Gradle Plugin version 7.1 #9

Closed
nksaroj opened this issue Mar 1, 2023 · 8 comments
Closed

Required minimum Android Gradle Plugin version 7.1 #9

nksaroj opened this issue Mar 1, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@nksaroj
Copy link
Contributor

nksaroj commented Mar 1, 2023

Worth removing the max check as it's breaking with higer versions

throw throw UnsupportedAGPVersionException("Required minimum Android Gradle Plugin version 7.1")

@2BAB
Copy link
Owner

2BAB commented Mar 1, 2023

Good idea. I think I can change it to a warning log that a higher AGP version is detected and it's not tested with the current Polyfill. Hopefully, I can make it along with AGP 7.4/8.0 next month.

@nksaroj
Copy link
Contributor Author

nksaroj commented Mar 1, 2023

I can raise PR if you want and can release quickly

@2BAB
Copy link
Owner

2BAB commented Mar 1, 2023

PR is welcome, will help with the following ci check and release.

@2BAB 2BAB added the enhancement New feature or request label Mar 1, 2023
@nksaroj
Copy link
Contributor Author

nksaroj commented Mar 2, 2023

@2BAB #10 is here for your approval.

@nksaroj
Copy link
Contributor Author

nksaroj commented Mar 2, 2023

@2BAB Do you know when it would be merged?

@2BAB
Copy link
Owner

2BAB commented Mar 2, 2023

Hi, @nksaroj I would merge and release by this evening (UTC+8).

@nksaroj
Copy link
Contributor Author

nksaroj commented Mar 2, 2023

Thanks I am waiting so I can pull for my work.. I need the bundle-tool-gradle-plugin But it seems that has the dependency on Polyfill.

@2BAB
Copy link
Owner

2BAB commented Mar 2, 2023

Released, it reflects on maven central already. https://repo1.maven.org/maven2/me/2bab/polyfill/0.8.1/

@2BAB 2BAB closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants