Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] reverted to custom popup #94 #83 #95

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

skkimeo
Copy link
Collaborator

@skkimeo skkimeo commented Jan 25, 2022

Popup

  • 외부 라이브러리를 사용했던 팝업을 기존의 custom popup 으로 대체
    • 팝업을 닫으려면 닫기 버튼을 눌러야 함
    • 팝업이 뜨면 배경에 회색 그림자 추가
    • 팝업 시 좌우 스와이프로 이동 불가
    • acarousel 과 popup 라이브러리 삭제
  • 이전에 팝업이 뜨면 밑의 캘린더가 맨 위로 다시 올라가버리는 문제 임시 해결
    • 팝업을 눌렀을 때와 스크롤 정도가 완벽하게 일치하지는 않지만 최소한 마지막으로 눌렀던 칸이 화면의 중앙에 보이도록 처리했습니다.

시뮬레이터에서는 계속 팝업의 툴바(닫기, 추가/수정 버튼)가 안 보이고 제 디바이스에서만 보이는데 혹시 두 분 디바이스에서도 잘 보이는 지 확인 부탁드립니다....흑흑

@skkimeo skkimeo added bug Something isn't working enhancement New feature or request labels Jan 25, 2022
@skkimeo skkimeo self-assigned this Jan 25, 2022
Copy link
Owner

@2unbini 2unbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 시뮬레이터에선 안 보이는데 실제 기기에서는 잘 됩니다!

Copy link
Collaborator

@tekim-526 tekim-526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@skkimeo skkimeo merged commit 8b408c0 into develop Jan 25, 2022
@skkimeo skkimeo deleted the feature/revert-to-custom-popup branch January 25, 2022 07:50
2unbini added a commit that referenced this pull request Feb 14, 2022
* [feat] iOS project file #1 (#2)

* [Feat] coreData DataModel setup #3 (#5)

* [feat] add DS_Store to gitignore (#7)

* [feat] Created Project List and Add, Edit Sheet UI #6 (#8)

* ProjectCalendarView (#13)

[feat] created ProjectCalendarView #9

* [feat] Created Popup, DailyTaskList, DailyTaskRowView, TaskDetailView #10 (#17)

* [feat] created .gitattributes for binary file & add *.xcuserdata to .gitignore #16

* [feat] update project binary file #18 (#19)

[feat] update project binary file #18

* [feat] added entity extensions and setup for core data #15  (#22)

* [feat] added entity extensions and setup for core data #15

* --amend

* [feat] Fetch data in Project List #25 (#28)

* [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23 (#31)

* [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23

* --amend

* deleted objectWillChange.send()

* [feat] refactored PoupUpTaskList #32 (#33)

merged

* [feat] Modify Data Type to normalize .sheet #35 (#36)

* [feat] Add Edit and Save Function #26 (#34)

* [feat] maxgrid #24 (#39)

* [feat] View Connection #40 (#42)

* [feat] Fixed Screen Separation in ProjectList #43 (#54)

* [feat] refactored views with projectId #48 (#53)

merge:)

* [feat] refactored modifiedForPredicates method #47 (#55)

머-지

* [feat] Passing Data including measured size #56 (#57)

* [feat] Separate Edit/AddSheet and ToolBar #44 (#58)

* [feat]fixing_bug(showing_day)_in_ProjectCalendarView (#61)

* [feat] Enhance Project List #45 (#64)

Add Swipe and delete and Edited Static list to dynamic with ForEach, Modified sheet action name

* [feat] Sheet Binding with Views #44 (#65)

* [feat]Change_Button_View #68 (#69)

* Feat/change dayn to int (#76)

* [feat]Change_Button_View #68

* [feat] Fix Task Add Sheet and Modified TempData #66 (#75)

* [feat] fixed popup bug in real device #52 (#70)

bug: empty popup on first tap

* [feat] shows CarouselView of TaskLists in Popup #37 (#73)

* [feat] Fix EditMode Separation in NavigationLink #43 (#79)

* [feat] changed popup animation to opacity #72 (#77)

* [feat] refactored coredata save method #27 #51 (#82)

* [feat] TaskList title shows date #71 (#81)

- also changed cancel button label

* [feat]refactoring_ProjectCalendarView #86 (#86)

* [feat]refactoring_ProjectCalendarView

* [feat]refactoring_ProjectCalendarView #86

* [feat]changeGridView (#87)

* [feat] Refator files and Separate by Folder #89 (#92)

* [feat] creating main calendar #88
* [feat] Refator files and Separate by Folder #89

Co-authored-by: sun <skkimeo@gmail.com>
Co-authored-by: tekim <rldod526@naver.com>

* [feat] Main Calendar Pair Programming #88 (#93)

Co-authored-by: tekim <rldod526@naver.com>
Co-authored-by: Eunbin Kwon <kwoneunbini@gmail.com>

* [feat] reverted to custom popup #94 #83 (#95)

- also fixed scroll bug related with popup

* [feat] refactored custom popup #94 #83 (#96)

- changed from func to view modifier 
- this conversion also fixed the scroll problem

* [feat] core data error handling done #38 (#97)

- shows alert when save fails

* [feat] little change of main calendar bar (#99)

* [feat] add tabBar Icon and Text #100 (#101)

* [feat] Enhance Project list #46, #59, #74 (#102)

* [feat] solve bug & change tabView Name #103 (#105)

* [feat]Disable Dark Mode #104 (#106)

* [feat]Disable Dark Mode #104

* [feat] Modify App Settings #107 (#109)

* [feat] Modify App Settings - Fix Orientation #107

* [feat] Modify App Settings - Localize Display Name #107

* [feat] Modify App Settings - Change Project Name #107

* [feat] Modify App Settings - Changed App name #107

* [feat] Modify App Settings - Fix App Name in Korean #107

* [feat] added app icons #110 (#111)

* [feat] changed bundle identifier #112 (#113)

Co-authored-by: sun <81314063+skkimeo@users.noreply.github.com>
Co-authored-by: tekim-526 <81205931+tekim-526@users.noreply.github.com>
Co-authored-by: tekim <rldod526@naver.com>
Co-authored-by: sun <skkimeo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants