-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Fixed Screen Separation in ProjectList #43 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skkimeo
approved these changes
Dec 19, 2021
tekim-526
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳입니다!
2unbini
added a commit
that referenced
this pull request
Feb 14, 2022
* [feat] iOS project file #1 (#2) * [Feat] coreData DataModel setup #3 (#5) * [feat] add DS_Store to gitignore (#7) * [feat] Created Project List and Add, Edit Sheet UI #6 (#8) * ProjectCalendarView (#13) [feat] created ProjectCalendarView #9 * [feat] Created Popup, DailyTaskList, DailyTaskRowView, TaskDetailView #10 (#17) * [feat] created .gitattributes for binary file & add *.xcuserdata to .gitignore #16 * [feat] update project binary file #18 (#19) [feat] update project binary file #18 * [feat] added entity extensions and setup for core data #15 (#22) * [feat] added entity extensions and setup for core data #15 * --amend * [feat] Fetch data in Project List #25 (#28) * [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23 (#31) * [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23 * --amend * deleted objectWillChange.send() * [feat] refactored PoupUpTaskList #32 (#33) merged * [feat] Modify Data Type to normalize .sheet #35 (#36) * [feat] Add Edit and Save Function #26 (#34) * [feat] maxgrid #24 (#39) * [feat] View Connection #40 (#42) * [feat] Fixed Screen Separation in ProjectList #43 (#54) * [feat] refactored views with projectId #48 (#53) merge:) * [feat] refactored modifiedForPredicates method #47 (#55) 머-지 * [feat] Passing Data including measured size #56 (#57) * [feat] Separate Edit/AddSheet and ToolBar #44 (#58) * [feat]fixing_bug(showing_day)_in_ProjectCalendarView (#61) * [feat] Enhance Project List #45 (#64) Add Swipe and delete and Edited Static list to dynamic with ForEach, Modified sheet action name * [feat] Sheet Binding with Views #44 (#65) * [feat]Change_Button_View #68 (#69) * Feat/change dayn to int (#76) * [feat]Change_Button_View #68 * [feat] Fix Task Add Sheet and Modified TempData #66 (#75) * [feat] fixed popup bug in real device #52 (#70) bug: empty popup on first tap * [feat] shows CarouselView of TaskLists in Popup #37 (#73) * [feat] Fix EditMode Separation in NavigationLink #43 (#79) * [feat] changed popup animation to opacity #72 (#77) * [feat] refactored coredata save method #27 #51 (#82) * [feat] TaskList title shows date #71 (#81) - also changed cancel button label * [feat]refactoring_ProjectCalendarView #86 (#86) * [feat]refactoring_ProjectCalendarView * [feat]refactoring_ProjectCalendarView #86 * [feat]changeGridView (#87) * [feat] Refator files and Separate by Folder #89 (#92) * [feat] creating main calendar #88 * [feat] Refator files and Separate by Folder #89 Co-authored-by: sun <skkimeo@gmail.com> Co-authored-by: tekim <rldod526@naver.com> * [feat] Main Calendar Pair Programming #88 (#93) Co-authored-by: tekim <rldod526@naver.com> Co-authored-by: Eunbin Kwon <kwoneunbini@gmail.com> * [feat] reverted to custom popup #94 #83 (#95) - also fixed scroll bug related with popup * [feat] refactored custom popup #94 #83 (#96) - changed from func to view modifier - this conversion also fixed the scroll problem * [feat] core data error handling done #38 (#97) - shows alert when save fails * [feat] little change of main calendar bar (#99) * [feat] add tabBar Icon and Text #100 (#101) * [feat] Enhance Project list #46, #59, #74 (#102) * [feat] solve bug & change tabView Name #103 (#105) * [feat]Disable Dark Mode #104 (#106) * [feat]Disable Dark Mode #104 * [feat] Modify App Settings #107 (#109) * [feat] Modify App Settings - Fix Orientation #107 * [feat] Modify App Settings - Localize Display Name #107 * [feat] Modify App Settings - Change Project Name #107 * [feat] Modify App Settings - Changed App name #107 * [feat] Modify App Settings - Fix App Name in Korean #107 * [feat] added app icons #110 (#111) * [feat] changed bundle identifier #112 (#113) Co-authored-by: sun <81314063+skkimeo@users.noreply.github.com> Co-authored-by: tekim-526 <81205931+tekim-526@users.noreply.github.com> Co-authored-by: tekim <rldod526@naver.com> Co-authored-by: sun <skkimeo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
적용 위치
ProjectList
적용 내용
Editmode 변수를 sheet로 함께 넘겨서 오류 해결