Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] fixed popup bug in real device #52 #50 #49 #70

Merged
merged 2 commits into from
Dec 26, 2021

Conversation

skkimeo
Copy link
Collaborator

@skkimeo skkimeo commented Dec 24, 2021

반영위치

  • ProjectCalendarView
  • PopupView

반영내용

  • @State 관련 버그로 인해 팝업이 최초로 나타나는 경우 빈 화면이 나타남. onChange(of:perform:) 을 사용해서 해결
  • 기존의 popup 메서드를 popup library로 대체
    • 애니메이션 관련 수정이 필요해서 파일 자체를 복붙해옴
    • 배경화면을 눌러서 팝업 닫기 가능
    • 제목을 아래로 내리면 슬라이드로 닫기도 가능
      • 이 부분은 변경 필요

그 외 자잘한 변경

  • TaskList 의 제목스타일을 inline 으로 바꿈
  • Cardify 의 프레임을 조정해서 팝업 시 뷰 크기 조정

bug: empty popup on first tap
@skkimeo skkimeo added the bug Something isn't working label Dec 24, 2021
@skkimeo skkimeo self-assigned this Dec 24, 2021
@skkimeo skkimeo changed the title [feat] fixed popup bug in real device #52 [feat] fixed popup bug in real device #52 #50 #49 Dec 24, 2021
Copy link
Owner

@2unbini 2unbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 !

Copy link
Collaborator

@tekim-526 tekim-526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProjectCalendarView 머지컴플릭트 해결화이팅입니다

@skkimeo skkimeo merged commit 41540f4 into develop Dec 26, 2021
skkimeo added a commit that referenced this pull request Dec 26, 2021
@skkimeo skkimeo deleted the feature/fix-popup-bug branch December 26, 2021 14:48
2unbini added a commit that referenced this pull request Feb 14, 2022
* [feat] iOS project file #1 (#2)

* [Feat] coreData DataModel setup #3 (#5)

* [feat] add DS_Store to gitignore (#7)

* [feat] Created Project List and Add, Edit Sheet UI #6 (#8)

* ProjectCalendarView (#13)

[feat] created ProjectCalendarView #9

* [feat] Created Popup, DailyTaskList, DailyTaskRowView, TaskDetailView #10 (#17)

* [feat] created .gitattributes for binary file & add *.xcuserdata to .gitignore #16

* [feat] update project binary file #18 (#19)

[feat] update project binary file #18

* [feat] added entity extensions and setup for core data #15  (#22)

* [feat] added entity extensions and setup for core data #15

* --amend

* [feat] Fetch data in Project List #25 (#28)

* [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23 (#31)

* [feat] integrated core data into PopUpTaskList, TaskList, TaskRowView, TaskDetailView #23

* --amend

* deleted objectWillChange.send()

* [feat] refactored PoupUpTaskList #32 (#33)

merged

* [feat] Modify Data Type to normalize .sheet #35 (#36)

* [feat] Add Edit and Save Function #26 (#34)

* [feat] maxgrid #24 (#39)

* [feat] View Connection #40 (#42)

* [feat] Fixed Screen Separation in ProjectList #43 (#54)

* [feat] refactored views with projectId #48 (#53)

merge:)

* [feat] refactored modifiedForPredicates method #47 (#55)

머-지

* [feat] Passing Data including measured size #56 (#57)

* [feat] Separate Edit/AddSheet and ToolBar #44 (#58)

* [feat]fixing_bug(showing_day)_in_ProjectCalendarView (#61)

* [feat] Enhance Project List #45 (#64)

Add Swipe and delete and Edited Static list to dynamic with ForEach, Modified sheet action name

* [feat] Sheet Binding with Views #44 (#65)

* [feat]Change_Button_View #68 (#69)

* Feat/change dayn to int (#76)

* [feat]Change_Button_View #68

* [feat] Fix Task Add Sheet and Modified TempData #66 (#75)

* [feat] fixed popup bug in real device #52 (#70)

bug: empty popup on first tap

* [feat] shows CarouselView of TaskLists in Popup #37 (#73)

* [feat] Fix EditMode Separation in NavigationLink #43 (#79)

* [feat] changed popup animation to opacity #72 (#77)

* [feat] refactored coredata save method #27 #51 (#82)

* [feat] TaskList title shows date #71 (#81)

- also changed cancel button label

* [feat]refactoring_ProjectCalendarView #86 (#86)

* [feat]refactoring_ProjectCalendarView

* [feat]refactoring_ProjectCalendarView #86

* [feat]changeGridView (#87)

* [feat] Refator files and Separate by Folder #89 (#92)

* [feat] creating main calendar #88
* [feat] Refator files and Separate by Folder #89

Co-authored-by: sun <skkimeo@gmail.com>
Co-authored-by: tekim <rldod526@naver.com>

* [feat] Main Calendar Pair Programming #88 (#93)

Co-authored-by: tekim <rldod526@naver.com>
Co-authored-by: Eunbin Kwon <kwoneunbini@gmail.com>

* [feat] reverted to custom popup #94 #83 (#95)

- also fixed scroll bug related with popup

* [feat] refactored custom popup #94 #83 (#96)

- changed from func to view modifier 
- this conversion also fixed the scroll problem

* [feat] core data error handling done #38 (#97)

- shows alert when save fails

* [feat] little change of main calendar bar (#99)

* [feat] add tabBar Icon and Text #100 (#101)

* [feat] Enhance Project list #46, #59, #74 (#102)

* [feat] solve bug & change tabView Name #103 (#105)

* [feat]Disable Dark Mode #104 (#106)

* [feat]Disable Dark Mode #104

* [feat] Modify App Settings #107 (#109)

* [feat] Modify App Settings - Fix Orientation #107

* [feat] Modify App Settings - Localize Display Name #107

* [feat] Modify App Settings - Change Project Name #107

* [feat] Modify App Settings - Changed App name #107

* [feat] Modify App Settings - Fix App Name in Korean #107

* [feat] added app icons #110 (#111)

* [feat] changed bundle identifier #112 (#113)

Co-authored-by: sun <81314063+skkimeo@users.noreply.github.com>
Co-authored-by: tekim-526 <81205931+tekim-526@users.noreply.github.com>
Co-authored-by: tekim <rldod526@naver.com>
Co-authored-by: sun <skkimeo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants