Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Thumbnail creating fix for SaveAs and Remix #396

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

Algorush
Copy link
Collaborator

@Algorush Algorush commented Feb 9, 2024

PR for Reviewing

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit 7c64987
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/65d6846fd5e52600093d3ae6
😎 Deploy Preview https://deploy-preview-396--3dstreet-editor-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfarr
Copy link
Contributor

kfarr commented Feb 21, 2024

How to test:

  • - as a user previously if I remix a scene the screenshot is not created; now see if it is created
  • - as a user if I create a new scene and press save, the screenshot should also be created
  • - as a user if I want to choose a new screenshot for existing scene, that function should still work

@kfarr
Copy link
Contributor

kfarr commented Feb 21, 2024

@Algorush thanks for this fix! testing worked great for all cases

@kfarr kfarr merged commit 18e0cc3 into master Feb 21, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants