Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same vertex faces and huge objects #71

Closed
TacogentP3D opened this issue Jan 10, 2024 · 0 comments
Closed

Same vertex faces and huge objects #71

TacogentP3D opened this issue Jan 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@TacogentP3D
Copy link

If an object has a face with at least 2 vertices with the same coordinates, that face does not affect the object's center of mass and inertia vectors, but does affect polylines
The currenly used method of slicing the object into 12 slices checks for vertices within 0.15 units from the slice plane, so if the object is really big, none of its vertices will intersect with any of the slices, grid2dv3a fixes this
The miner is using the reversed mining method, first finding a combination of polylines and then constructing an object from them, to do this it's first generating a normal random object and scaling it up until none of its vertices intersect with any of the 12 slice planes, then adds the polyline points as same vertex faces since they don't affect the object's rotation, the scaled up random object does not affect the hash, it just makes the object look normal
A possible fix is to discard any such faces and start using grid2dv3a's slicing algorithm

@PaulSff PaulSff added the enhancement New feature or request label Jan 12, 2024
mishk pushed a commit that referenced this issue Jan 29, 2024
mishk pushed a commit that referenced this issue Feb 8, 2024
@PaulSff PaulSff closed this as completed Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants