Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation #1

Closed
ocimjr opened this issue Nov 25, 2023 · 2 comments
Closed

Optimisation #1

ocimjr opened this issue Nov 25, 2023 · 2 comments

Comments

@ocimjr
Copy link

ocimjr commented Nov 25, 2023

Since your code was moved, I cannot comment on old threat.

By chance, I was searching for a hairmidi replacement for mac, I found this https://github.com/RuudMulder/SerialMidiBridge/blob/main/SerialMidiBridge.py

He used thread and midi on his code. This can maybe help to not use "while" to wait for midi messages.

Hope it helps,

@3hhh
Copy link
Owner

3hhh commented Nov 25, 2023 via email

@ocimjr
Copy link
Author

ocimjr commented Nov 25, 2023

He is using rtmidi see lines 23 and 24.
Is true he is not using Asyncio, but he is use threading,

s_watcher = threading.Thread(target = serial_watcher)

Maybe this could be use in the same way with asyncio

@3hhh 3hhh closed this as completed in c5a4340 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants