Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port blackhole to Visual Studio 2017 #190

Open
Maturin opened this issue Nov 30, 2018 · 1 comment
Open

Port blackhole to Visual Studio 2017 #190

Maturin opened this issue Nov 30, 2018 · 1 comment

Comments

@Maturin
Copy link
Contributor

Maturin commented Nov 30, 2018

blackhole does not build with Visual Studio 2017. (I haven't tired it yet, but my educated guess is, other Visual Studio compiler won't work either.)

More or less a prerequisite for implementing this issue are #186 and #188.

Maturin added a commit to Maturin/blackhole that referenced this issue Nov 30, 2018
@Maturin
Copy link
Contributor Author

Maturin commented Dec 1, 2018

@3Hren: I pushed my changes to my repo. It would be great, if you could already a look at it.

Primary what is left do are some cleanups. Especially I want to replace reoccurring constructs like the one below with calling a function, which does this only one time for each system function. In total I had to do this for 4 system functions.

#ifdef _MSC_VER
    ::gmtime_s(&tm, &time);
#else
    ::gmtime_r(&time, &tm);
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant