-
Notifications
You must be signed in to change notification settings - Fork 27
Evaluate making fetchedResultsController private #27
Comments
DO IT! |
Done #29 |
Hey @3lvis , just curious what the reasoning was for making fetchedResultsController private. I have a need to subclass DATASource and it requires access to fetchedResultsController. I guess I can make a fork, but would rather not... |
Hi @bonebox, At the beginning it started with making convenience methods for handling common operations, using fetchedResultsController methods felt way too verbose: =>
=>
=>
=>
=>
=>
Then the issue with changing the fetchedResultsController's predicate started, updating the DATASource/Source/DATASource.swift Lines 79 to 94 in 535147d
|
Btw, what problem are you trying to solve? Maybe we can find another solution. |
Hey @3lvis, thanks for the explanation--that's understandable. Perhaps a happy medium would be making it read-only? For example, As for the problem I'm trying to solve - I need to subclass |
Actually after looking at it further, a few more of the properties/methods would also need to be made public/read-only in order to accomplish what I want to do. The |
Anyway, don't worry about this. It's more of an edge-case that hardly anyone will likely need. I'll just create a fork and make my changes there. Thanks! |
Hi Jeremy, Thanks for taking the time of explaining. I understood what you're trying to achieve. I'm sure your users will appreciate the extra work that takes making something like this. I can imagine why it would be useful. I hope it works out for you, if I can help in anything just let me know. Have a nice weekend! |
No description provided.
The text was updated successfully, but these errors were encountered: