Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EnvoyConfig and EnvoyConfigRevision secret namespace required field #61

Closed
slopezz opened this issue Dec 4, 2020 · 0 comments · Fixed by #90
Closed

Update EnvoyConfig and EnvoyConfigRevision secret namespace required field #61

slopezz opened this issue Dec 4, 2020 · 0 comments · Fixed by #90
Assignees

Comments

@slopezz
Copy link
Member

slopezz commented Dec 4, 2020

Now that DiscoveryService is namespace scope since #60, there is no need to specify the namespace on the secret ref spec:

  envoyResources:
    secrets:
      - name: kuard-certificate
        ref:
          name: kuard-certificate
          namespace: default  ### This one

Because being DS a namespace scope resource, means that secret must live on the NS where DS/EC are deployed, so having that required namespace field is redundant and not needed to be added by the end customer defining the EC.

Documentation, examples... will need to be updated reflecting that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants