Update nokogiri to 1.13.10 #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.10 to 1.13.10. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.10...v1.13.10) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
It's been deprecated
# Conflicts: # Gemfile.lock
|
Can't be merged due to the licenses CI job, I'll merge this later on when #3148 is merged |
|
@dependabot rebase |
|
I think it will not rebase due to extra changes on top of its own :( |
|
But also it cannot run the licenses task by itself. I wonder if that can be automated.. |
akostadinov
reviewed
Mar 3, 2023
| @@ -60,7 +60,7 @@ def setup | |||
| get :show | |||
|
|
|||
| assert_response :success | |||
| page = Nokogiri::HTML::Document.parse(response.body) | |||
| page = Nokogiri::HTML4::Document.parse(response.body) | |||
There was a problem hiding this comment.
Nokogiri::HTML as been deprecated and it's now called Nokogiri::HTML4 (see release notes). For the present version there's an alias so both are still working, but the former will be removed in future versions, so I'm advancing the work.
jlledom
changed the title
thalesmiguel
previously approved these changes
Mar 9, 2023
josemigallas
previously approved these changes
Mar 13, 2023
akostadinov
previously approved these changes
Mar 15, 2023
# Conflicts: # Gemfile.lock # doc/licenses/licenses.xml
jlledom
dismissed stale reviews from akostadinov, josemigallas, and thalesmiguel
via
ffb9f42
thalesmiguel
approved these changes
Mar 22, 2023
|
You have to rebase, otherwise changes get messed up :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Nokogiri to fix some vulnerabilities
I have no idea why my changes weren't committed to #3137. I'm creating this PR to continue with the issue.
The name
Nokogiri::HTMLhas been deprecated, now it'sNokogiri::HTML4. Better change it now to avoid future problems when they remove the old name.Also some tests failed and I had to fix them.