Replace foldLeft with traverse in Decoders #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 87.81% 88.14% +0.32%
==========================================
Files 36 36
Lines 517 506 -11
Branches 3 3
==========================================
- Hits 454 446 -8
+ Misses 63 60 -3
Continue to review full report at Codecov.
|
| it should "return an error for an empty list" in { | ||
| decode[NonEmptyList[Int]](emptyListResponse) should be('left) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it might be worth it to add a test case for a single element because I think that's why this decoder is here for in the first place.
Something like:
case class Foo(a: Int)
it should "return a valid NonEmtpyList for a valid JSON" in {
decode[NonEmptyList[Foo]]("""{"a": 1}""") should be(Right(NonEmptyList.of(Foo(1))))
}What do you think?
There was a problem hiding this comment.
Hmm this seems to be a bit dodgy decoder, converting both A and [A], but as that seems what is needed, I'll add that test 👍
There was a problem hiding this comment.
agreed, the github api and its quirks ...
No description provided.