Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump travis 2.12 version to 2.12.3 #166

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Conversation

suhasgaddam
Copy link
Contributor

github4s is pulling the crossScalaVersions from sbt-org-policies. It has 2.12 has 2.12.3 which is different than travis's 2.12.2. The release task has a filter that only allows it to run for the latest crossScalaVersion.

Reference links in some order:
https://github.com/47deg/sbt-org-policies/blob/v0.7.5/core/src/main/scala/sbtorgpolicies/model.scala#L138

https://github.com/47deg/github4s/blob/master/project/ProjectPlugin.scala#L94

https://travis-ci.org/47deg/github4s/jobs/279420156#L2119
https://travis-ci.org/47deg/github4s/jobs/279420156#L2121

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @suhasgaddam !

@suhasgaddam suhasgaddam merged commit cd982bd into master Sep 25, 2017
@suhasgaddam suhasgaddam deleted the release-0.16.0-round-2 branch September 25, 2017 17:36
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7282077). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage          ?   87.11%           
=========================================
  Files             ?       42           
  Lines             ?      621           
  Branches          ?        5           
=========================================
  Hits              ?      541           
  Misses            ?       80           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7282077...fe7bd45. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants