Fetch issue comments #188
Merged
Fetch issue comments #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
reviewed
Jan 9, 2018
docs/src/main/tut/issue.md
Outdated
| - the repository coordinates (`owner` and `name` of the repository). | ||
| - `number`: The issue number. | ||
|
|
||
| To create a comment: |
| issues.listComments(None, headerUserAgent, validRepoOwner, validRepoName, validIssueNumber) | ||
| response should be('left) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you're missing the mocked responses: http://47deg.github.io/github4s/contributing.html#mocking-the-responses
|
@BenFradet yes, it is helpful. I got a good overview of what has to be done. |
GRBurst
force-pushed
the
fetchIssueComments
branch
2 times, most recently
from
10f5140
to
e05fa05
Compare
|
@BenFradet fixed btw - sry for the late ping |
juanpedromoreno
approved these changes
Jan 15, 2018
|
@GRBurst Could you rebase against master? |
GRBurst
force-pushed
the
fetchIssueComments
branch
from
e05fa05
to
2d7bb43
Compare
GRBurst
force-pushed
the
fetchIssueComments
branch
from
2d7bb43
to
c5e18ac
Compare
fedefernandez
approved these changes
Jan 23, 2018
|
Thanks @fedefernandez , merging 👍 |
|
Thanks @BenFradet for taking care |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
fixes #186. Already used it successfully in my fork.
Fits contributing guidelines I think.
Kind regards