Change param so we are filtering by label #204
Conversation
There was a problem hiding this comment.
Looks good 👍 , could you add a label search param to https://github.com/47deg/github4s/blob/b166c8706999191e67128f09744793070811c905/github4s/shared/src/test/scala/github4s/utils/TestData.scala#L75-L79 I just labelled #40 with enhancement
Thanks for catching the bug!
|
@BenFradet Just updated TestData.scala
Hey my pleasure. Thanks for making a dope library. I am just starting to learn a bit of Scala and using this in a little toy project has been super clear and easy. |
| @@ -74,6 +74,7 @@ trait TestData extends DummyGithubUrls { | |||
| val nonExistentSearchQuery = "nonExistentSearchQueryString" | |||
| val validSearchParams = List( | |||
| OwnerParamInRepository(s"$validRepoOwner/$validRepoName"), | |||
| LabelParam(label = "bug"), | |||
There was a problem hiding this comment.
Unfortunately this will fail since this test is used to retrieve the issue #40 which is labelled enhancement, that's what I meant in my review sorry if I wasn't clear.
|
0.18.4 has been published and contains your fix 👍 |
Resolves #203.