Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Project #91

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Upgrades Project #91

merged 2 commits into from
Apr 21, 2017

Conversation

juanpedromoreno
Copy link
Member

This PR brings some changes:

  • Fixes ScalaJS tests (and also moves tests to proper package location).
  • Upgrades sbt-org-policies plugin version.
  • Excludes scalaz module from code coverage.
  • Simplifies travis.yml, checking the org policies through orgScriptCI task.
  • Releases new patch version.

Please, @fedefernandez could you review? Thanks!

* Fixes scalajs tests
* Excludes scalaz module from code coverage
* Upgrades sbt-org-policies plugin version
* Releases new patch version
@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #91 into master will increase coverage by 6.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   81.54%   87.69%   +6.15%     
==========================================
  Files          37       36       -1     
  Lines         531      512      -19     
  Branches        2        2              
==========================================
+ Hits          433      449      +16     
+ Misses         98       63      -35
Impacted Files Coverage Δ
...4s/shared/src/main/scala/github4s/HttpClient.scala 78.57% <ø> (+3.57%) ⬆️
...cala/github4s/free/interpreters/Interpreters.scala 85% <ø> (ø) ⬆️
...red/src/main/scala/github4s/api/PullRequests.scala 100% <ø> (ø) ⬆️
...thub4s/shared/src/main/scala/github4s/Github.scala 80% <ø> (-4.62%) ⬇️
...scala/github4s/HttpRequestBuilderExtensionJS.scala 86.95% <ø> (+86.95%) ⬆️
...cala/github4s/HttpRequestBuilderExtensionJVM.scala 100% <ø> (ø) ⬆️
...s/shared/src/main/scala/github4s/api/GitData.scala 100% <ø> (ø) ⬆️
...b4s/shared/src/main/scala/github4s/Implicits.scala 41.66% <ø> (+4.16%) ⬆️
...b4s/shared/src/main/scala/github4s/api/Gists.scala 100% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3724b...0f3c2be. Read the comment docs.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@juanpedromoreno juanpedromoreno merged commit f6f1191 into master Apr 21, 2017
@juanpedromoreno juanpedromoreno deleted the jp-upgrade-project branch April 21, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants