Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidebar nested options support #108

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Add sidebar nested options support #108

merged 5 commits into from
Aug 6, 2019

Conversation

calvellido
Copy link
Collaborator

  • This adds sidebar menu nested options support, along other minor stylistic and structure changes for a better file organization and project maintenance.

This closes #97

@calvellido calvellido mentioned this pull request Aug 6, 2019
Closed
@47degdev
Copy link
Contributor

47degdev commented Aug 6, 2019 •
edited
Loading

Hood benchmark comparison:
✔️ Decoding (Threshold: 125.11399119324493)

Benchmark Value
master_benchmark 10807.237231187337
helios_benchmark 11084.988763013569

⚠️ Decodingfromraw (Threshold: 250.0)

Benchmark Value
master_benchmark 7219.359677463459
helios_benchmark 7120.900013526004

🔴 Parsing (Threshold: 250.0)

Benchmark Value
master_benchmark 21845.069744379518
helios_benchmark 20391.689744766405

AntonioMateoGomez
AntonioMateoGomez approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@AntonioMateoGomez AntonioMateoGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calvellido calvellido merged commit 284482e into master Aug 6, 2019
@calvellido calvellido deleted the jv-97-sidebar-nested-options branch August 6, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioMateoGomez AntonioMateoGomez AntonioMateoGomez approved these changes

@israelperezglez israelperezglez Awaiting requested review from israelperezglez

@AdrianRaFo AdrianRaFo Awaiting requested review from AdrianRaFo

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar menu nested options support
4 participants
@calvellido @47degdev @AntonioMateoGomez @AdrianRaFo