Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-click to turn on signature #6

Closed
tvercaut opened this issue Oct 12, 2020 · 2 comments
Closed

Right-click to turn on signature #6

tvercaut opened this issue Oct 12, 2020 · 2 comments

Comments

@tvercaut
Copy link

Thanks for updating signature switch to TB 78!

One of the features I miss from the previous version is the ability to turn on the signature from a right click in the email body.

I know the menu is now on the top right and there is also a keyboard shortcut for it but would personally like the right-click path back.

@Colonel-Badger
Copy link

Me too! This was the main thing I used Signature Switch for actually so would really like this functionality back please :-)

I appreciate you can also do it with a customised shortcut key but right click was just a fast.

Thank you too for the upgrade to TB 78.

@4ch1m
Copy link
Owner

4ch1m commented Oct 12, 2020

A dynamic context menu is already implemented in Signature Switch's code:

...

function createContextMenu() {
    browser.menus.remove(MENU_ROOT_ID);

    browser.storage.local.get().then(localStorage => {
        let menuItems = [];

        menuItems.push({
            id: MENU_ROOT_ID,
            title: i18n("extensionName"),
            contexts: [
                // TODO
                // the MailExtension-API lacks a suitable context-type for the composer-window;
                // so this won't work atm
                "editable"
            ]
        });

...

However, the current MailExtension-API doesn't offer a hook to add it to the composer window. This will hopefully change in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants