Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported filetypes for resources #3862

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

arthuro555
Copy link
Contributor

[Untested]

Adds webm, jpeg and webp as supported formats in the IDE. Those formats are all already supported by PIXI, widely used, fast and modern (except JPEG)

@arthuro555 arthuro555 requested a review from 4ian as a code owner April 27, 2022 22:38
@4ian
Copy link
Owner

4ian commented Apr 28, 2022

Can we get a table of support across browsers? We might want to warn users for formats not supported widely.

@Silver-Streak
Copy link
Collaborator

I was just digging into this to respond to a forum post. Seems that most if not all modern browsers support it, and electron 18 (if not much older) would as well.

https://developers.google.com/speed/webp/faq

@tristanbob
Copy link
Contributor

Can we get a table of support across browsers? We might want to warn users for formats not supported widely.

I love this website for these type of questions:

https://caniuse.com/webp
91.38% (supported) + 1.83% (partially supported) = 93.21%

https://caniuse.com/webm
77% (supported) + 17.3% (partially supported) = 94.30%

@4ian
Copy link
Owner

4ian commented Apr 28, 2022

CanIUse is good indeed - the Google resource strangely does not indicate Safari support.

webm is not supported on iOS 13, but the usage is declining to <2% of iOS and because it's not mandatory to use, just a new possibility, I think it's fine then!

@4ian 4ian merged commit d9ea04e into 4ian:master Apr 29, 2022
@arthuro555 arthuro555 deleted the patch-1 branch April 29, 2022 23:11
@Bouh
Copy link
Collaborator

Bouh commented Apr 30, 2022

[Untested]

Did someone test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants