Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable updater prompt by passing --disable-update-check in cmd #887

Merged
merged 4 commits into from
Jan 19, 2019
Merged

Disable updater prompt by passing --disable-update-check in cmd #887

merged 4 commits into from
Jan 19, 2019

Conversation

blurymind
Copy link
Contributor

@blurymind blurymind commented Jan 17, 2019

mini pull to disable automatic update checks on the electron app by passing a --disable-update-check parameter to its executable

request here
#882

@4ian
Copy link
Owner

4ian commented Jan 17, 2019

As mentionned in the other pull request, better add a command line option for it. Look for arguments in LocalApp.js. Pass it somehow to the _checkUpdates method of PreferencesProvider.js :)

@blurymind blurymind changed the title Disable updater prompt Disable updater prompt by passing --disable-update-check in cmd Jan 18, 2019
@blurymind
Copy link
Contributor Author

I think this should do it. I just need a bit more time to update flow checks

newIDE/app/src/BrowserApp.js Outdated Show resolved Hide resolved
@4ian
Copy link
Owner

4ian commented Jan 19, 2019

Looks very good to me! Maybe we should think at some place where to document these command lines flags... ideally launching gdevelop with --help should display them.

Merging as this looks good to me!

@4ian 4ian merged commit 9a95aab into 4ian:master Jan 19, 2019
@blurymind
Copy link
Contributor Author

This is an excellent idea. It shouldn't be hard to add,but I am not sure what it will say. Do we have other parameters than can be passed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants