Add 'StringList' as new parameter type for extensions

[Wend1go]

There is just a small "uglyness" (see below)

[Wend1go]

[4ian]

Sweet!
Two things as you can see on SemaphoreCI: https://semaphoreci.com/4ian/gd/branches/pull-request-911/builds/2

• Flow is warning you that Cannot call parameterMetadata.getExtraInfo because property getExtraInfo is missing in undefined
  

This means that you have to add a if case or handle in some way the case where "parameterMetadata" is undefined (which can happen if the field is used in some strange conditions).

• Run npm run format/yarn format to auto format your code.

Do you intend to use this soon for an extension? Or is it more to prepare things for later extensions?

[Wend1go]

I wanted to use it in the Tween extension. But I still need to do some research on how Tween.js works and how it best fits into the GD workflow.

I'll add the check and format this evening.
Did I get you right that getExtraInfo() will keep the ExtensionName:: prefix for the foreseeable future?
In this case I would change the replace function into "erase everything on the left up to the double colon ::.

[4ian]

Did I get you right that getExtraInfo() will keep the ExtensionName:: prefix for the foreseeable future?

No I think I'll remove the prefix (precisely, I'll apply the prefix only for parameters that are objects).

[Wend1go]

Ok done 😃

[Wend1go]

I wonder if it is possible to edit the list of items bound to the StringListField from within the extension that uses it.
That way it would be possible to automatically show a list of identifiers from already existing tween animations or identifiers of scene and object timers.

[4ian]

FYI, I'll do the changes but got carried out by other things when working on translations :)

[Wend1go]

No problem, I'll probably spend the next two weeks on the tweening extension. I'll switch to the StringLists shortly before the extension is ready.

[4ian]

I've fixed the "extra info" and added handling of "stringWithSelector", understood as a string by the game engine. "stringWithSelector" sounded better because the type sent to the JS function is a string, not a list/array of strings.

To use this:

• Merge master branch into your branch.
• Remove newIDE/app/srclibGD.js file
• Relaunch npm run start or yarn start.

Let me know if it works.
You'll have to change "stringlist" to "stringWithSelector" and rename your file for consistency. Apart from this, should work like before!

[Wend1go]

I couldn't find libGD.js under the path you mentioned. Or did you meanGDevelop/newIDE/app/public/libGD.js?
After removing the file it got downloaded again but when I parse extraInfo there is still the preceeding ClassName::
In other words, I couldn't test this yet.

EDIT:
BTW, is this possible?

[4ian]

You have to merge master branch in your branch ;)

you mean GDevelop/newIDE/app/public/libGD.js

Yes sorry, this file. Merge master, delete it and relaunch npm run start so that it get downloaded

[4ian]

I wonder if it is possible to edit the list of items bound to the StringListField from within the extension that uses it.

No easy way, we would need some kind of abstraction allowing to declare types of identifiers.
And have IDE scan the events to detect those who are declared, like variables, and a place where to store them, like variables

[Wend1go]

Ok the items are correctly shown now.
But the returned value in my test extension is an empty string.
Have to go to work now, I'll look into this when I come home.

[Wend1go]

Guess I found the culprit. Will test it tonight.

[4ian]

Oh thinking about it now, as this is considered as a string, you have to ensure that quotes are in your values:

        dataSource={this._choices.map(choice => ({
          text: choice,
          value: '"' + choice + '"',
        }))}

[Wend1go]

Now it is working :)

[4ian]

Sweet! Looks good for me to merge

[4ian]

Ran Prettier on your file, remember to run yarn format before committing ;)

[4ian]

Merged! Thanks for adding this and look forward to see it being used in the Tween extension :)