Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twistd example wrong? #5

Closed
teuben opened this issue Apr 21, 2020 · 3 comments
Closed

twistd example wrong? #5

teuben opened this issue Apr 21, 2020 · 3 comments

Comments

@teuben
Copy link

teuben commented Apr 21, 2020

The quick and dirty example in the README file claims to run

 twistd -n comet -v --local-ivo=ivo://fpstoolstest/foo#bar --remote=voevent.4pisky.org

but it seems that --remote needs to be replaced by --subscribe.

@timstaley
Copy link
Member

Hi @teuben ,
Thanks for the report... I am guessing that you've install comet directly from the repo-master branch?

It looks like John has switched to a new api around a year ago, cf
jdswinbank/Comet@55887b2#diff-2ee53d9b780c4dc33604e0e213946592
but hasn't made a release since then - so the docs and the version installable via pip both use the older syntax, still.

I'll keep this issue open as a reminder to add a note in the docs about comet-versions.

@teuben
Copy link
Author

teuben commented Apr 23, 2020

I did a "pip install comet" indeed.

@timstaley
Copy link
Member

Hi @teuben ,

I didn't quite follow that - did you do a pip install comet and that fixed it? Or that was your original install method?

For what it's worth, a fresh install from PyPI of comet works fine for me:

mkvirtualenv testcomet
#...

pip install comet
# ...

pip show comet
#Name: Comet
#Version: 3.1.0
#Summary: VOEvent Broker
# ...

# Always a good one to try if you're not 100% sure which version you're actually getting:
python -c "import comet; print(comet.__path__)" 
# ['/home/staley/.virtualenvs/testcomet/lib/python3.6/site-packages/comet']

twistd -n comet -v --local-ivo=ivo://fpstoolstest/foo#bar --remote=voevent.4pisky.org
# ... (Runs fine)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants