Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumblr: Support downloading a link to a single post (perhaps helpful for reddit rips) #590

Open
acceleracer opened this issue Jun 25, 2017 · 10 comments

Comments

@acceleracer
Copy link

Expected Behavior

Expected software to download all 3 pictures.

Actual Behavior

It looks like the download is starting and then it stops with the message: Error:null

Log:
Downloading http://api.tumblr.com/v2/blog/ask-human-octavia.tumblr.com/posts?id=159080635200&api_key=JFNLu3CbINQjRdUvZibXW9VpSEVYYtiPJ86o8YmvgLZIoKyuNX
Rip complete, saved to /Users/user/Desktop/RipMe/rips/tumblr_ask-human-octavia.tumblr.com_post_159080635200
null

@metaprime metaprime added the bug label Jun 25, 2017
@metaprime metaprime added this to the On-deck for 1.5.x milestone Jun 25, 2017
@cyian-1756
Copy link
Contributor

I can't repo this

Tried on Ubuntu 16.04 using openJDK 1.8.0_131

@rautamiekka
Copy link

rautamiekka commented Jun 25, 2017

@acceleracer Why are you on an old Java ?

@Norithiel
Copy link

@rautamiekka windows 10, java version "1.8.0_131" - same problem

@lostes
Copy link

lostes commented Jul 6, 2017

Can confirm. I have the same problem.
Ripme v1.5.2
Java: 1.8.0_131
Windows 10

@Hrxn
Copy link

Hrxn commented Jul 6, 2017

Expected Behavior

Expected software to download all 3 pictures.

Wait, you're trying just this single post?

Not sure, normally Ripme is used like this <user>.tumblr.com, i.e. the whole tumblr log.

Did it ever work on a single post? Wasn't really taken into consideration, I think, because if all you want is some images from a single post, you can download them manually.

@Norithiel
Copy link

Problem was with api-key. It worked after its updating.

@metaprime metaprime added enhancement and removed bug labels Aug 14, 2017
@metaprime metaprime changed the title Can't download from Tumblr, Error:null Tumblr: Support downloading a link to a single post (perhaps helpful for reddit rips) Aug 14, 2017
@ohhdemgirls
Copy link

Please do this!!

@Gauravwdh
Copy link

Error while loading http://api.tumblr.com/v2/blog/ask-human-octavia.tumblr.com/posts?id=152562762965&api_key=JFNLu3CbINQjRdUvZibXW9VpSEVYYtiPJ86o8YmvgLZIoKyuNX
org.jsoup.HttpStatusException: HTTP error fetching URL. Status=429, URL=http://api.tumblr.com/v2/blog/ask-human-octavia.tumblr.com/posts?id=152562762965&api_key=JFNLu3CbINQjRdUvZibXW9VpSEVYYtiPJ86o8YmvgLZIoKyuNX
at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:459)
at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:434)
at org.jsoup.helper.HttpConnection.execute(HttpConnection.java:181)
at com.rarchives.ripme.utils.Http.response(Http.java:130)
at com.rarchives.ripme.utils.Http.getJSON(Http.java:120)
at com.rarchives.ripme.ripper.rippers.TumblrRipper.rip(TumblrRipper.java:122)
at com.rarchives.ripme.ripper.AbstractRipper.run(AbstractRipper.java:353)
at java.lang.Thread.run(Thread.java:745)
Got exception while running ripper:
java.lang.NullPointerException
at com.rarchives.ripme.ripper.rippers.TumblrRipper.handleJSON(TumblrRipper.java:182)
at com.rarchives.ripme.ripper.rippers.TumblrRipper.rip(TumblrRipper.java:159)
at com.rarchives.ripme.ripper.AbstractRipper.run(AbstractRipper.java:353)
at java.lang.Thread.run(Thread.java:745)
Waiting for threads to finish
Rip completed!

Getting 429(API limit reached) in logs.

@indy-singh
Copy link

I get the same issues. I get a HTTP 429 back.

{"meta":{"status":429,"msg":"Limit Exceeded"},"response":[],"errors":[{"title":"Limit Exceeded","detail":"It did not work"}]}

I think the solution is to allow the user to provide their own API key.

Cheers,
Indy

@Hrxn
Copy link

Hrxn commented Nov 16, 2017

You can set your own API key within rip.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants