Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure minimum six version for tests is 1.12.0 #171

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Ensure minimum six version for tests is 1.12.0 #171

merged 1 commit into from
Dec 2, 2019

Conversation

buchi
Copy link
Member

@buchi buchi commented Dec 2, 2019

We require at least six 1.12.0 in packages ported to Python 3.
However Plone < 5.2 pins six to a lower version.

@buchi buchi mentioned this pull request Dec 2, 2019
Merged
@jone
Copy link
Member

jone commented Dec 2, 2019

@buchi Do we want that for Plone 4 and 5 or just for Plone 5?
We also have a test-versions-plone-5.cfg if we want it only for Plone 5..

@buchi
Copy link
Member Author

buchi commented Dec 2, 2019

We need it for Plone 4.3, 5.0 and 5.1

jone
jone approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@jone jone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jone jone merged commit 01bb1d4 into master Dec 2, 2019
@jone jone deleted the min-six-version branch December 2, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jone jone jone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buchi @jone