-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plone 5.2 and Python 3 support #197
Conversation
Fixes an issue with sorting of upgrade steps.
Required by argcomplete
Python 2.7 does not support 'rb'
I tried it out, and seems to work on 5.2 Py 3. Note that I don't use the zcml upgrade steps, so I did not test those. I have one problem though.
The version restriction was added in 2015 to avoid a conflict with This could be done outside of this PR too, but it is most necessary for Python 3. Workaround for users: do not add |
The version restriction was added to avoid a conflict with six pinnings by older Plone versions (Plone <= 4.3.8 and <= 5.0.2).
@mauritsvanrees thanks for your feedback! I've removed the version constraint for I've also cherry-picked your fix for the port number into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the mostly small and granular commits. Made reviewing this a bit easier.
Some comments/suggestions, but nothing that would block a merge. Some things i mentioned were fixed in later commits. Apart from that LGTM 👍.
Did a testrun upgrading https://github.com/4teamwork/opengever.core/ from 2019.1
to 2020.1
. Worked flawlessly from what i can tell ✨.
It's no longer needed as of Plone 5.2.1
@deiferni @mauritsvanrees thans for reviewing! |
Adds support for Plone 5.2 and Python 3
Mainly compatibility fixes. Uses Plone's
installer
view PLIP 1340 if available and falls back to QuickInstaller if not.