Scrub HTTP response headers #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deiferni
suggested changes
Jan 28, 2019
| """We do not use the Bobo exception headers for anything.""" | ||
|
|
||
| def __call__(self): | ||
| def _setBCIHeaders(self, t, tb): |
There was a problem hiding this comment.
i'm quite unhappy about the continuous use of monkey patches 😞 . we should use them as a last resort only. You might have already considered this but just to be sure, is there an event-handler you could register instead of patching and then scrub the headers again? Maybe IPubFailure would work?
deiferni
approved these changes
Jan 28, 2019
deiferni
approved these changes
Jan 28, 2019
|
And for reference, pushing for it to get removed upstream for Zope 4. |
|
I've dropped the added test for the now-reverted rerisen error body scrubbing. Ready for rereview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftw.testbrowserto allow for not following redirects to test 302 response headers and bodiesZPublisher.interfaces.IPubEndto scrub the server version stringOriginal implementation of setting Bobo Call Interface headers onto responses:
https://github.com/zopefoundation/Zope/blob/d916c812bdaf518053b0c3cb2cb3545ff73bc288/src/ZPublisher/HTTPResponse.py#L758-L787
Closes #5185