Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 10系統のサポート #43

Closed
515hikaru opened this issue May 25, 2020 · 2 comments
Closed

Node.js 10系統のサポート #43

515hikaru opened this issue May 25, 2020 · 2 comments
Labels
wontfix This will not be worked on

Comments

@515hikaru
Copy link
Owner

やれるならやった方がいいよね

@515hikaru
Copy link
Owner Author

Array#flat は Node.js 10 では使えないらしい。

Babel と Jest の設定をちゃんとすれば動くのではないかと思ったが、一旦は無視することにした

% npm run test 

> pnovel@0.4.5-dev test /home/hikaru/ghq/src/github.com/515hikaru/pnovel
> jest

 FAIL  __tests__/parser_test.js
  ● parser › parse testing

    TypeError: l.flat is not a function

      1030 | 
      1031 |     function makeLine(l) {
    > 1032 |       const chars = l.flat(2)
           |                       ^
      1033 |       return chars.join("").trim().replace(/(\r\n|\n|\r)/gm, "")
      1034 |     }
      1035 | 

      at makeLine (parser/parser.js:1032:23)
      at peg$c5 (parser/parser.js:158:21)
      at peg$parsesentence (parser/parser.js:694:14)
      at peg$parseblock (parser/parser.js:384:16)
      at peg$parsedoc (parser/parser.js:357:10)
      at peg$startRuleFunction (parser/parser.js:347:10)
      at peg$parse (parser/parser.js:1042:16)
      at Object.test (__tests__/parser_test.js:53:12)

 PASS  __tests__/eval_test.js

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 5 passed, 6 total
Snapshots:   0 total
Time:        1.262 s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pnovel@0.4.5-dev test: `jest`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the pnovel@0.4.5-dev test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/hikaru/.npm/_logs/2020-05-26T14_26_11_918Z-debug.log

@515hikaru 515hikaru added this to the v1.0.0 milestone May 26, 2020
@515hikaru 515hikaru added the wontfix This will not be worked on label May 26, 2020
@515hikaru 515hikaru removed this from the v1.0.0 milestone Jun 27, 2020
@515hikaru
Copy link
Owner Author

無理にしなくて良い気がしてきた。対応しない。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant