Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix todos in comments #13

Closed
5 tasks done
akshay-ap opened this issue Jun 27, 2023 · 0 comments · Fixed by #59
Closed
5 tasks done

Fix todos in comments #13

akshay-ap opened this issue Jun 27, 2023 · 0 comments · Fixed by #59
Assignees
@akshay-ap
Labels
documentation Improvements or additions to documentation
Milestone
v0.1.0

Comments

@akshay-ap
Copy link
Contributor

akshay-ap commented Jun 27, 2023 •
edited
Loading

Following Contracts have TODOs for natspec documentation:

  • SafeProtocolManager
  • SafeProtocolRegistry
  • ISafeProtocolManager (Integrations interface)
  • Plugin interface
  • Hooks interface
@akshay-ap akshay-ap self-assigned this Jun 27, 2023
@akshay-ap akshay-ap added the documentation Improvements or additions to documentation label Jun 27, 2023
@akshay-ap akshay-ap added this to the v0.1.0 milestone Jun 27, 2023
@akshay-ap akshay-ap mentioned this issue Jun 27, 2023
Merged
9 tasks
akshay-ap added a commit that referenced this issue Jul 3, 2023
@akshay-ap
[#4 #13] Update natspec docstring in ISafeProtocolMediator interface
ba6d113
akshay-ap added a commit that referenced this issue Jul 3, 2023
@akshay-ap
[#4 #13] Update natspec docstring in ISafeProtocolMediator interface
d9af1ab
akshay-ap added a commit that referenced this issue Jul 3, 2023
@akshay-ap
[#4 #13] Update natspec docstring in ISafeProtocolMediator interface
ccf7c6e
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#13] Update natspec doc in Integrations.sol
b064f2c
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#13] Pass address of Plugin in hooks as executionMeta parameter
51ba721
@akshay-ap akshay-ap mentioned this issue Aug 2, 2023
Merged
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#13] Update natspec
12bbc4d
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#13] Update link to specs
1826b7c
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2023
@akshay-ap @mmv08
Fix todos (#59)
aae5d88 
* [#13] Update natspec doc in Integrations.sol

* [#13] Pass address of Plugin in hooks as executionMeta parameter

* Update contracts/interfaces/Integrations.sol

Co-authored-by: Mikhail <mveehkim@gmail.com>

* Update contracts/interfaces/Integrations.sol

Co-authored-by: Mikhail <mveehkim@gmail.com>

* Update contracts/interfaces/Integrations.sol

Co-authored-by: Mikhail <mveehkim@gmail.com>

* [#13] Update natspec

* [#13] Update link to specs

---------

Co-authored-by: Mikhail <mveehkim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Fix todos 5afe/safe-core-protocol
1 participant
@akshay-ap