-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module mediator #12
Merged
Merged
Module mediator #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction, rename struct MoudleAccessInfo
…tocol into feature-4-module-mediator
rmeissner
reviewed
Jun 23, 2023
rmeissner
reviewed
Jun 23, 2023
rmeissner
reviewed
Jun 23, 2023
[#19] Generate typings for solidity contracts
…eate tx variables
akshay-ap
force-pushed
the
feature-4-module-mediator
branch
2 times, most recently
from
July 3, 2023 08:57
ba6d113
to
d9af1ab
Compare
mmv08
reviewed
Jul 3, 2023
akshay-ap
force-pushed
the
feature-4-module-mediator
branch
from
July 3, 2023 09:07
d9af1ab
to
ccf7c6e
Compare
mmv08
reviewed
Jul 3, 2023
mmv08
reviewed
Jul 3, 2023
mmv08
reviewed
Jul 3, 2023
mmv08
approved these changes
Jul 4, 2023
There is still pending action left - the |
created another issue here #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 and partially addresses #6
Changes in PR:
- Users can add Mediator as a module
- User can enable module through registry with root or non-root access
- Contract emits events on successful execution or fail execution
- Contract emits events on adding module for a safe
- Validate if user asked to enable module with root/non-root acces
Module mediator tests:
Additional changes:
TODOs related to natspec will be handled later in #13.