Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if a module implements required interface when adding to registry #16

Closed
2 tasks done
akshay-ap opened this issue Jun 29, 2023 · 0 comments · Fixed by #48
Closed
2 tasks done

Check if a module implements required interface when adding to registry #16

akshay-ap opened this issue Jun 29, 2023 · 0 comments · Fixed by #48
Assignees
@akshay-ap
Labels
enhancement New feature or request
Milestone
v0.1.0

Comments

@akshay-ap
Copy link
Contributor

akshay-ap commented Jun 29, 2023 •
edited
Loading

  • Inherit IERC165 interface in component interfaces
  • When adding a module to a registry, add check in registry that it implements right interface id.
@akshay-ap akshay-ap self-assigned this Jun 29, 2023
@akshay-ap akshay-ap added the enhancement New feature or request label Jun 29, 2023
@akshay-ap akshay-ap added this to the v0.1.0 milestone Jun 29, 2023
@akshay-ap akshay-ap mentioned this issue Jun 29, 2023
Merged
9 tasks
akshay-ap added a commit that referenced this issue Jun 29, 2023
@akshay-ap
[#4, #16] Remove todo related to checking interface id when enabling …
65a45ea 
…module
@akshay-ap akshay-ap mentioned this issue Jul 11, 2023
Merged
akshay-ap added a commit that referenced this issue Jul 24, 2023
@akshay-ap
[#16] Check if integration supports valid interfaceId when adding to …
116b2f4 
…registry, inherit SafeProtocolRegistry in test registry
@akshay-ap akshay-ap mentioned this issue Jul 24, 2023
Merged
akshay-ap added a commit that referenced this issue Jul 25, 2023
@akshay-ap
[#16] Add tests
88af3c5
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Make event parameters indexed in SafeProtocolRegistry
7aa862b
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Use target property in test instead of getAddress() in Regi…
2e71d44 
…stry tests
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Use target instead of getAddress() in mock builders
040bde0
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Update import in tsconfig.json to resolve import error
3915ee3
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Use setupTests()function
a8a0063
akshay-ap added a commit that referenced this issue Aug 1, 2023
@akshay-ap
[#16] Temp: Experimental changes
18ad58d
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#16] Fix failing build
310b16b
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#16] Fix failing build
1c6f689
akshay-ap added a commit that referenced this issue Aug 2, 2023
@akshay-ap
[#16] Update import in tsconfig.json to resolve import error
92f0dd2
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2023
@akshay-ap
Fix import issues in test (#58)
d0caefd 
* [#16] Fix failing build

* [#16] Update import in tsconfig.json to resolve import error
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2023
@akshay-ap
Check if integration supports valid interfaceId (#48)
0a7b86c 
* [#16] Check if integration supports valid interfaceId when adding to registry, inherit SafeProtocolRegistry in test registry

* [#16] Add tests

* [#16] Make event parameters indexed in SafeProtocolRegistry

* [#16] Use `target` property in test instead of `getAddress()` in Registry tests

* [#16] Use `target` instead of `getAddress()` in mock builders

* [#16] Update import in tsconfig.json to resolve import error

* [#16] Use `setupTests()`function

* [#16] Fix failing build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Check if integration supports valid interfaceId 5afe/safe-core-protocol
1 participant
@akshay-ap