Release v3.11.0 #2587

dasanra · 2021-07-28T10:51:19Z

Features

Use separate RPC endpoint for Safe Apps (Feature: Use separate rpc endpoint in safe apps #2563)
Enhance Safe Apps fetching logic (Feature: enhanced safe app info fetching logic #2569)
Add breadcrumbs to app sections (Add breadcrums to app sections #2547)

Fixes

Fix importing the address boook in Windows 10 + Chrome (Fix import in Windows 10 + Chrome #2582)
Creating an spending limit tries to enable the module again (Spending limit - Creating a spending limit is trying to add the module again #2549)
Disable spellchecker in ETH address input (Disable the spellchecker in the address field #2257)
Safe incorrectly created when changing connected owner on step two (Dont reset variables that dont need update #2552)
Required is shown in load safe form right after loading the page (Don't show required error when loading a safe #2574)

Chores

Bump dependencies (Upgrade dependencies #2580)
Remove truffle dependency from project (Remove truffle dependency #2577)
Add hooks for running e2e tests (Add hook for running e2e tests #2551) (Added github action to run e2e on each PR #2561)
Add centralized routing source (Add centralized routing source #2536)
Config options cleanup (Chore: remove unused options from the configs #2564)
Use Gateway SDK for most of the gateway calls (Use Gateway SDK for most of the gateway calls #2522)

* Add test action to launch e2e tests * Add name to github job * Update event-type name * Run e2e after rinkeby build on dev

* Add centralize route proposal for settings * Use centralize routes for address book and transactions * Set Apps route and path in root route components * Use makeEntryItem function to avoid code repetition on useSidebarItems

* remove safeAppsUrl, safeRelayServiceUrl, fix ethgasstation for mainnet * fix tests

* Add separate property for safe apps rpc url * fix polygon rpc url * add safe apps rpc token env var to ci * bring ethgasstaction api key back * change infura project id env var name

* Added github action * Added action to comment on e2e success * Check e2e test status to comment success or fail

* Use Menu and Breadcrumb components in Balances, Transactions, Apps and Settings * Clean unused styles on settings

* Upgrade sentry dependencies * Upgrade bnc-onboard and dependencies with minor changes

* use image fetching func that is not affected by cors * use arrow functions

* Use gateway-sdk for safe info and balances * Collectibles * Replace fiat currencies endpoint * Load transaction history via the SDK * Add transaction queue * Set released version from safe-react-gateway-sdk Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Added useMemo to update safeModules

github-actions · 2021-07-28T10:51:36Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2021-07-28T10:55:19Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	5	0
Ignored	15	N/A

Result: ✅ success
Annotations: 5 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/logic/safe/store/middleware/notificationsMiddleware.ts Line 80 - Argument 'store' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 80 - Argument 'next' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 80 - Missing return type on function.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 80 - Argument 'action' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 52 - Argument 'values' should be typed.

^{Report generated by eslint-plus-action}

github-actions · 2021-07-28T10:58:15Z

Safe Multisig app mainnet

github-actions · 2021-07-28T10:58:48Z

Safe Multisig app volta

github-actions · 2021-07-28T10:58:55Z

Safe Multisig app xdai

github-actions · 2021-07-28T10:59:11Z

Safe Multisig app rinkeby

github-actions · 2021-07-28T10:59:12Z

Safe Multisig app polygon

github-actions · 2021-07-28T10:59:17Z

Safe Multisig app bsc

github-actions · 2021-07-28T10:59:51Z

Safe Multisig app energy_web_chain

francovenica · 2021-07-30T02:39:20Z

Major issue: #2591

dasanra · 2021-07-30T08:09:05Z

@francovenica so unexpected 😉 already patched 👌

francovenica · 2021-07-30T21:11:44Z

The release branch looks fine.
What it was possible to test functionally in the ticket description I've checked already
Made a regression in rinkeby and it worked fine
the issue with the "Remove safe" button was fixed
Tested BSC and worked fine
Tested Poly and I had some issues with gas estimation (sometimes it would take a few tries to finally do the estimation) but I attribute that to the issues we have seen later this week
Checked the google analytics while doing the testing, making sure it shows in the live feed whenever I was navigating.

Looks good to me

katspaugh

⭐️

github-actions · 2021-08-02T10:41:30Z

E2E Tests Failed

fmrsabino and others added 19 commits July 16, 2021 13:41

Update Polygon staging environment config (#2545)

58a2aed

Add hook for running e2e tests (#2551)

5fc5aa3

* Add test action to launch e2e tests * Add name to github job * Update event-type name * Run e2e after rinkeby build on dev

Merge branch 'dev' into release/3.10.0

4724a5f

Add centralized routing source (#2536)

a73c0f4

* Add centralize route proposal for settings * Use centralize routes for address book and transactions * Set Apps route and path in root route components * Use makeEntryItem function to avoid code repetition on useSidebarItems

Disable spellchecker in eth address field - re #2257 (#2557)

fd22f6e

Chore: remove unused options from the configs (#2564)

5ef21d5

* remove safeAppsUrl, safeRelayServiceUrl, fix ethgasstation for mainnet * fix tests

Dont reset variables that dont need update (#2552)

9939cf6

Feature: Use separate rpc endpoint in safe apps (#2563)

b3763d2

* Add separate property for safe apps rpc url * fix polygon rpc url * add safe apps rpc token env var to ci * bring ethgasstaction api key back * change infura project id env var name

Added github action to run e2e on each PR (#2561)

ff9ae50

* Added github action * Added action to comment on e2e success * Check e2e test status to comment success or fail

Adds Binance Smart Chain and Polygon to list (#2575)

c3c3019

Add breadcrums to app sections (#2547)

220bc69

* Use Menu and Breadcrumb components in Balances, Transactions, Apps and Settings * Clean unused styles on settings

Upgrade dependencies (#2580)

71432ed

* Upgrade sentry dependencies * Upgrade bnc-onboard and dependencies with minor changes

Restore Transactions event tracking for Google Analytics (#2576)

8ddf40a

Fix import in Windows 10 + Chrome (#2582)

5d27d3a

Initialize safeName with undefined in stead of empty string (#2574)

ffcbe90

Feature: enhanced safe app info fetching logic (#2569)

d8012a6

* use image fetching func that is not affected by cors * use arrow functions

Remove truffle dependency (#2577)

1db8332

Created auxiliary function to check if a module is enabled (#2570)

035ef54

* Added useMemo to update safeModules

Update navigation method after removing a Safe

47dee02

dasanra mentioned this pull request Jul 30, 2021

Removing a safe crashes the site #2591

Closed

dasanra requested a review from katspaugh August 2, 2021 10:23

Set v3.11.0

28b8662

katspaugh approved these changes Aug 2, 2021

View reviewed changes

dasanra merged commit 28b8662 into main Aug 2, 2021

github-actions bot locked and limited conversation to collaborators Aug 2, 2021

katspaugh deleted the release/v3.11.0 branch August 3, 2021 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v3.11.0 #2587

Release v3.11.0 #2587

dasanra commented Jul 28, 2021 •

edited

Loading

github-actions bot commented Jul 28, 2021 •

edited

Loading

github-actions bot commented Jul 28, 2021 •

edited

Loading

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

francovenica commented Jul 30, 2021 •

edited

Loading

dasanra commented Jul 30, 2021

francovenica commented Jul 30, 2021

katspaugh left a comment

github-actions bot commented Aug 2, 2021

Release v3.11.0 #2587

Release v3.11.0 #2587

Conversation

dasanra commented Jul 28, 2021 • edited Loading

Features

Fixes

Chores

github-actions bot commented Jul 28, 2021 • edited Loading

github-actions bot commented Jul 28, 2021 • edited Loading

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

francovenica commented Jul 30, 2021 • edited Loading

dasanra commented Jul 30, 2021

francovenica commented Jul 30, 2021

katspaugh left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2021

dasanra commented Jul 28, 2021 •

edited

Loading

github-actions bot commented Jul 28, 2021 •

edited

Loading

github-actions bot commented Jul 28, 2021 •

edited

Loading

francovenica commented Jul 30, 2021 •

edited

Loading