Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add level field to spells generally and by class (and whatever has a "level" field that gets prewarmed into Redis) #411

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

BenTracyDotCom
Copy link
Contributor

What does this do?

Adds level field to returned general and class (short) spell data

How was it tested?

npm test & practical test on local machine

Is there a Github issue this is resolving?

No

Was any impacted documentation updated to reflect this change?

N/A

Here's a fun image for your troubles

random photo - update me

@BenTracyDotCom BenTracyDotCom changed the title Add level field to spells generally and by class (and whatever has a "level" field that gets prewarmed into Redis) feat: Add level field to spells generally and by class (and whatever has a "level" field that gets prewarmed into Redis) Feb 23, 2024
Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update https://github.com/5e-bits/docs as well? The docs should reflect this change.

@BenTracyDotCom
Copy link
Contributor Author

Can you please update https://github.com/5e-bits/docs as well? The docs should reflect this change.

Updated docs and PR'd

Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I made sure all tests pass. However, this is blocked by some changes you need to make on the Docs PR.

@bagelbits
Copy link
Collaborator

Related Docs PR:
5e-bits/docs#33

@bagelbits bagelbits merged commit 01f5f0e into 5e-bits:main Apr 10, 2024
1 of 2 checks passed
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants