Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security issues #4

Closed
obfusk opened this issue Mar 28, 2024 · 1 comment
Closed

security issues #4

obfusk opened this issue Mar 28, 2024 · 1 comment

Comments

@obfusk
Copy link

obfusk commented Mar 28, 2024

Hi! I noticed the following:

GeneratePasswordViewModel.generateRandomPassword() uses java.util.Random -- which is not cryptographically secure -- instead of java.security.SecureRandom.

EncryptionHelper logs plaintext and keys; understandable for debugging but not something that should occur on users' devices.

(Additionally, I noticed the typo "lenght" a few times.)
@6eero
Copy link
Owner

6eero commented Mar 28, 2024

Fixed it, thank you 🙏🏻

@6eero 6eero closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obfusk @6eero