Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRowFromNode negative value when greater than 2147483647 #371

Closed
vin-e opened this issue May 10, 2019 · 0 comments
Closed

getRowFromNode negative value when greater than 2147483647 #371

vin-e opened this issue May 10, 2019 · 0 comments

Comments

@vin-e
Copy link

vin-e commented May 10, 2019

We are using a provider model, similar to the remote model, with very large datasets. We recently ran into an issue where the data set is larger than the 32-bit int safe max value of 2,147,483,647. When calling getCellFromEvent via a context menu click we are getting a negative number returned as the row.

Within getRowFromNode it is currently returning a bitwise or operation to ensure that the value is an integer. When returning a number larger than the 32-bit safe int max it starts rolling into negative numbers.

I've tested locally by changing the return value in getRowFromNode to return return +row without any noticeable bugs and returning the correct row number.

If you have any alternative ways to get the row from the context menu click, without going through the getCellFromEvent, we are open to hearing about it as well.

Thanks

vin-e added a commit to vin-e/SlickGrid that referenced this issue May 13, 2019
fix 6pac#371 for number larger than 2.14 billion
@6pac 6pac closed this as completed in e4a7fe4 May 15, 2019
6pac added a commit that referenced this issue May 15, 2019
fix #371 for number larger than 2.14 billion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant