Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce proposed open-source project related files #5

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Introduce proposed open-source project related files #5

merged 2 commits into from
Mar 2, 2022

Conversation

frasermcc9
Copy link
Contributor

@frasermcc9 frasermcc9 commented Mar 1, 2022 •
edited
Loading

Description

PR for adding files and configs needed for an open source project.

Recommend discussing desired modifications on: #4

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

Leave blank if not applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@frasermcc9 frasermcc9 mentioned this pull request Mar 1, 2022
Closed
@frasermcc9 frasermcc9 linked an issue Mar 1, 2022 that may be closed by this pull request
Open Source Related Files #4
Closed
@frasermcc9 frasermcc9 added chore miscellaneous minor changes discussion further discussion is requested rfc request for comment labels Mar 1, 2022
j-chad
j-chad approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@j-chad j-chad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this. Seems like no other comments so I think you can merge now :)

@frasermcc9 frasermcc9 merged commit bf616e2 into 701-T4:main Mar 2, 2022
@frasermcc9 frasermcc9 deleted the fmcc091-chore/oss-files branch March 2, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-chad j-chad j-chad approved these changes

Assignees
No one assigned
Labels
chore miscellaneous minor changes discussion further discussion is requested rfc request for comment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open Source Related Files
2 participants
@frasermcc9 @j-chad