-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Source Related Files #4
Comments
Good point, the nature of CODEOWNERS should make this possible since the default owner of any code is everyone in the group. We can define more specific ownership for certain files if needed, i.e. we might have a couple people who become very familiar with something like a db schema file, so it makes sense any changes to that would be reviewed by someone in that group. |
add in a prettier config later when we have the yarn workspace set up |
Is your feature request related to a problem? Please describe.
Its important to give contributors context and information about how to contribute to the project. This thread will discuss root-level files that we would want in our project.
Describe the solution you'd like
I propose the following configs and documents:
License
I'm defaulting to MIT but if anyone has a preference (i.e. gpl family) then please discuss.
Contributing.md
A summary guide on how the project should be contributed to, such as git conventions, code review conventions etc.
Readme.md
A file introducing the project, and usage for end users.
.gitignore and .gitattributes
Repo related files to be ignored and gitattributes to enforce things like line endings and treating files as binary. Going to suggest that if you haven't already, I suggest placing your IDE and OS files in a global gitignore since these aren't really relevant to the repo.
CODE_OF_CONDUCT.md
Outlines the rules for contributing. I suggest we just use one like this
CODEOWNERS
Gives us the ability to assign ownership over certain parts of the code. This means contributors know who to ask for reviews when modifying files or directories (and can even be set as a branch protection requirement). Keen to hear others thoughts on this.
.editorconfig
Apply some global styling rules (although may be unneeded if we are going with the monorepo structure).
Anything else?
If anything here seems unneeded, adjusting, or anything is missing, please discuss below.
Implemented in #5
The text was updated successfully, but these errors were encountered: