Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshalling cyclic objects crashes the interpreter #27

Closed
71104 opened this issue Dec 27, 2014 · 3 comments
Closed

Unmarshalling cyclic objects crashes the interpreter #27

71104 opened this issue Dec 27, 2014 · 3 comments
Assignees
Labels

Comments

@71104
Copy link
Owner

71104 commented Dec 27, 2014

To test this, simply evaluate process, which seems to be cyclic in Node 0.10.25.

@71104 71104 self-assigned this Dec 27, 2014
@71104 71104 added the bug label Dec 28, 2014
@71104
Copy link
Owner Author

71104 commented Dec 31, 2014

This might need to be fixed by extending the domain and introducing another type of values, the "native objects". This is because unmarshalling native objects into Lambda objects every time a field is accessed is not the best solution, the evaluation of the field access node should require O(1) time.

@71104
Copy link
Owner Author

71104 commented Jul 12, 2015

This needs to be readdressed, see #48.

@71104
Copy link
Owner Author

71104 commented Jul 12, 2015

This has been readdressed in #48, but the new solution doesn't completely fix arrays.

Example of a valid JavaScript array that cannot be unmarshaled (an exception is thrown in Lambda):

var x = [];
x.push(x);

@71104 71104 reopened this Jul 12, 2015
@71104 71104 closed this as completed in 0cdf7b4 Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant