Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logging functionalities #4

Closed
mdallastella opened this issue Jul 25, 2019 · 3 comments
Closed

Implement logging functionalities #4

mdallastella opened this issue Jul 25, 2019 · 3 comments
Assignees
@manuel-uberti
Labels
enhancement New feature or request
Milestone
0.1.4

Comments

@mdallastella
Copy link
Collaborator

We can use timbre to implement logging functionalities.
@mdallastella mdallastella added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Jul 25, 2019
@mdallastella mdallastella added this to the 0.1.4 milestone Jul 25, 2019
@manuel-uberti manuel-uberti self-assigned this Jul 25, 2019
@manuel-uberti
Copy link
Contributor

I added timbre and configured a basic file appender: 8ec0f94

What do we log now? :)

@manuel-uberti
Copy link
Contributor

Turns out it's better to let shelob user take care of logging and handle exceptions.

@manuel-uberti
Copy link
Contributor

Note that the basic file appender needs to be configured, otherwise shelob's clients will find a shelob.log file in the root of their projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuel-uberti manuel-uberti

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.4
Development

No branches or pull requests
2 participants
@mdallastella @manuel-uberti