Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink our approach to configurations #1886

Open
pshirshov opened this issue Feb 1, 2023 · 0 comments
Open

Rethink our approach to configurations #1886

pshirshov opened this issue Feb 1, 2023 · 0 comments
Assignees
@neko-kai
Labels
distage (di) enhancement good first issue Good for newcomers
Projects
DIStage
Milestone
1.3

Comments

@pshirshov
Copy link
Member

typesafe-config causes several problems:

  1. We have to customize pureconfig heavily
  2. typesafe-config and pureconfig are not available outside of JVM

Essentially we have at least 2 options to make our config extension working on SJS:

  1. We may use https://github.com/ekrich/sconfig for both JVM and SJS. Pureconfig still would have to be re-implemented
  2. We may use native JSON objects on SJS and rely on circe to decode them.

This issue is a continuation of #1290
@pshirshov pshirshov added this to the 1.2 milestone Feb 1, 2023
@pshirshov pshirshov added this to To do in DIStage via automation Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neko-kai neko-kai

Labels
distage (di) enhancement good first issue Good for newcomers
Projects
DIStage
  
To do
Milestone
1.3
Development

No branches or pull requests
2 participants
@pshirshov @neko-kai