Fix gentoo support #284
Merged
Fix gentoo support #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch includes multiple fixes: - the local repository no longer gets automatically updated. Other package managers dont do this either and the output can include something about an error, that isnt actually a problem, which causes distrobox-init to fail. - there are multiple curl packages for gentoo. net-misc/curl is the web request tool. - vte-profile doesnt exist for gentoo. The closest package is probably vte. - some packages compilation will report errors, which get ignored by the build tools, so dont matter, but the mention will cause distrobox-init to abort. To prevent this --quiet-build is used to supress to messages from compilation
Apparently the ci wants different command line args than described in CONTRIBUNTING.md. CONTRIBUNTING.md should be updated
|
CONTRIBUNTING.md recommends using shfmt -s but the ci uses shfmt -s -ci -sr -kp. Should i update CONTRIBUTING.md? |
I've updated it 😄 |
|
LGTM, thanks for the contribution! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch includes multiple fixes:
package managers dont do this either and the output can include
something about an error, that isnt actually a problem, which causes
distrobox-init to fail.
request tool.
vte.
build tools, so dont matter, but the mention will cause distrobox-init
to abort. To prevent this --quiet-build is used to supress to messages
from compilation