Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to use http #1

Closed
MrRacoon opened this issue Feb 12, 2015 · 3 comments · Fixed by #2
Closed

option to use http #1

MrRacoon opened this issue Feb 12, 2015 · 3 comments · Fixed by #2

Comments

@MrRacoon
Copy link

Awesome API, I had to make an alteration though to use http. I may not be doing it right but I at least got it working after playing with your code. Maybe you wanna add the option to index.js?

var protocol = opts.insecure ? 'http://' : 'https://'
var url = protocol+.....
@8bitDesigner
Copy link
Owner

First off, I'd really recommend against using HTTP as a transport with this library, as it means you're sending your password across the wire in plaintext, which is a Very Bad Thing (tm).

That said, if you can't work around that issue, lemme know if this branch fixes things for you: #2

You can install it by changing the dependency entry for your project to:

{
  "dependencies": {
    "tp-api": "https://github.com/8bitDesigner/tp-api.git#insecure-protocol-support"
  }
}

@8bitDesigner
Copy link
Owner

Also, my team's moved onto Jira, so I can't really test or support this library any more. If you have any interest in supporting this project, let me know, and I'll give you commit access and make you a contributor on the NPM project, so you can push new versions.

@MrRacoon
Copy link
Author

Thanks! Again thanks for the code, I needed it to create a POC for an internal tool and this was a HUGE help. I agree that enabling http isn't really the right solution, in my instance, it happened to be the only/quickest solution for the time frame. That said, TP isn't exactly my forte, so I'm not really your guy. Thanks again, great work, appretiate the response. You gave me exactly what I needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants