Cleanup schema binding code #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vektah
force-pushed
the
cleanup-type-binding
branch
from
ed75078
to
c89a877
Compare
danielmai
pushed a commit
to outcaste-io/gqlgen
that referenced
this pull request
Mar 18, 2022
fix(GraphQL): This PR change dgraph-io version to v2.1.1 in go.mod file.
StevenACoffman
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Allow WebsocketInitFunc to add payload to Ack The connection ACK message in the protocol for both graphql-ws and graphql-transport-ws allows for a payload in the connection ack message. We really wanted to use this to establish better telemetry in our use of websockets in graphql. * Fix lint error in test * Switch argument ordering. --------- Co-authored-by: Chris Pride <cpride@observeinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits a bunch of code out of the main package, and breaks it down into smaller functions.
Most importantly, scalars are now defined in a way that can be overridden in types.json. Not too useful on its own, but it will make custom scalars easier to implement.
I've also split Type from NamedType, which I think has really helped readability in templates.
Generated code is bit for bit identical.